bittabola/tarjimon
1
0
Fork 0
Code Issues Pull requests Packages 1 Activity Actions

Auto: fix/pr26-review-suggestions #27

Merged
claude-bot merged 1 commit from fix/pr26-review-suggestions into main 2026-03-01 20:53:33 -07:00
Conversation 1 Commits 1 Files changed 1 +17 -11
claude-bot commented 2026-03-01 20:52:19 -07:00
Collaborator
Copy link

Automated PR for branch fix/pr26-review-suggestions.

Automated PR for branch `fix/pr26-review-suggestions`.
Address PR #26 review suggestions
All checks were successful
Auto PR Review / review (push) Successful in 1m52s
Details
b41164957c 
- Extract untracked-file warning into reusable warn-untracked script
  to deduplicate across three commit steps
- Add empty-commit guard to ruff-commit step to handle mtime-only
  changes from ruff that produce no actual diff
- Add "no git commands" instruction to review-fix prompt for
  consistency with lint/test-fix prompt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude-bot commented 2026-03-01 20:53:32 -07:00
Author
Collaborator
Copy link

Approved

Clean DRY refactoring that consolidates a duplicated untracked-files warning into a shared helper script, fixes the ruff auto-format step to gracefully skip commits when there are no changes, and adds a sensible prompt instruction preventing Claude from running git commands. No bugs, security issues, or bad practices found.

Suggestions

  • .forgejo/workflows/auto-pr-merge.yml: Consider declaring shell: bash on the "Configure git" step (or setting defaults.run.shell: bash at the job level) to ensure the heredoc and warn-untracked script creation always use bash, matching the explicit shell: bash used by the calling steps. Currently the step has no explicit shell, so it falls back to sh, which works but is inconsistent with the rest of the workflow.
  • .forgejo/workflows/auto-pr-merge.yml: Minor: the warn-untracked script uses echo to output the warning but doesn't exit non-zero. This is correct for a warning, but adding a brief inline comment like # warn only, don't fail would make the intent clearer for future maintainers.
## Approved Clean DRY refactoring that consolidates a duplicated untracked-files warning into a shared helper script, fixes the ruff auto-format step to gracefully skip commits when there are no changes, and adds a sensible prompt instruction preventing Claude from running git commands. No bugs, security issues, or bad practices found. ### Suggestions - **.forgejo/workflows/auto-pr-merge.yml**: Consider declaring `shell: bash` on the "Configure git" step (or setting `defaults.run.shell: bash` at the job level) to ensure the heredoc and `warn-untracked` script creation always use bash, matching the explicit `shell: bash` used by the calling steps. Currently the step has no explicit shell, so it falls back to `sh`, which works but is inconsistent with the rest of the workflow. - **.forgejo/workflows/auto-pr-merge.yml**: Minor: the `warn-untracked` script uses `echo` to output the warning but doesn't exit non-zero. This is correct for a warning, but adding a brief inline comment like `# warn only, don't fail` would make the intent clearer for future maintainers.
claude-bot deleted branch fix/pr26-review-suggestions 2026-03-01 20:53:33 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bittabola/tarjimon!27
No description provided.